Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner message UI test case #19529

Merged

Conversation

YangJiao0817
Copy link
Member

Fix #19272

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Nov 3, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner November 3, 2023 07:16
@YangJiao0817 YangJiao0817 self-assigned this Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #19529 (92d9abc) into main (3f7c605) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19529      +/-   ##
==========================================
+ Coverage   44.96%   45.00%   +0.03%     
==========================================
  Files         243      243              
  Lines       13354    13354              
  Branches     2737     2737              
==========================================
+ Hits         6005     6010       +5     
+ Misses       7044     7040       -4     
+ Partials      305      304       -1     
Flag Coverage Δ
unittests 45.00% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Fix goharbor#19272

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) November 6, 2023 02:51
@YangJiao0817 YangJiao0817 merged commit e1a4423 into goharbor:main Nov 6, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add banner message UI test case
5 participants