Use absolute path for the profile.cov #19535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
added
the
release-note/ignore-for-release
Codecov Report
@@ Coverage Diff @@
## main #19535 +/- ##
===========================================
+ Coverage 44.91% 67.50% +22.58%
===========================================
Files 243 988 +745
Lines 13354 108777 +95423
Branches 2737 2737
===========================================
+ Hits 5998 73428 +67430
- Misses 7051 31384 +24333
- Partials 305 3965 +3660
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
approved these changes
Nov 6, 2023
There's a path change introduced by goharbor#19508 which may impact showing the coverage on codecov. This commit makes sure the profile.cov is referenced as absolute path in `coverage4gotest.sh` Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
coverage-profile-path
branch
from
eb45947
to
19ecaff
Compare
reasonerjt
changed the title
reasonerjt
assigned chlins and wy65701436 and unassigned wy65701436, AllForNothing and MinerYang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a path change introduced by #19508 which may impact showing the coverage on codecov.
This commit makes sure the profile.cov is referenced as absolute path in
coverage4gotest.shThank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: