Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed ClrDropdownItem causing menu closure #19555

Conversation

jmichot-exotec
Copy link
Contributor

@jmichot-exotec jmichot-exotec commented Nov 8, 2023

Comprehensive Summary of your change

Removed ClrDropdownItem component from 'Add Labels' box because clicking on this component leads to menu closure.

Issue being fixed

Fixes #19554
Closes #19554

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@jmichot-exotec jmichot-exotec marked this pull request as ready for review November 8, 2023 09:54
@jmichot-exotec jmichot-exotec requested a review from a team as a code owner November 8, 2023 09:54
Signed-off-by: Julien Michot <julien.michot.ext@exotec.com>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #19555 (80b616a) into main (f6d5bf2) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19555      +/-   ##
==========================================
+ Coverage   67.53%   67.55%   +0.01%     
==========================================
  Files         990      990              
  Lines      109021   109021              
  Branches     2719     2719              
==========================================
+ Hits        73629    73644      +15     
+ Misses      31426    31409      -17     
- Partials     3966     3968       +2     
Flag Coverage Δ
unittests 67.55% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@AllForNothing
Copy link
Contributor

AllForNothing commented Nov 10, 2023

@jmichot-exotec Thanks for your PR.
But your changes will cause another issue(The dropdown will not be closed), see the screen record:

Screen.Recording.2023-11-10.at.12.05.41.mov

I created a new PR #19561 to fix the issue, so I'm closing this one

@jmichot-exotec
Copy link
Contributor Author

@AllForNothing Oh sorry I did not notice that, thanks for opening the new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot filter labels
5 participants