fix: increase beego max memory and upload size #19578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Increase the default beego max memory and upload size from 32GB to 128GB. 2. Support customize the two beego configs from env. Signed-off-by: chlins <chenyuzh@vmware.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19578 +/- ##
==========================================
- Coverage 67.53% 67.52% -0.02%
==========================================
Files 991 991
Lines 109140 109144 +4
Branches 2719 2719
==========================================
- Hits 73708 73698 -10
- Misses 31458 31474 +16
+ Partials 3974 3972 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I'm not sure increasing the limit is the solution for this issue; larger images will have the same problem. The registry and client need to agree on max size of the blob, and if the layer exceeds that, it needs to be split into more chunks. |
|
Because they are beego specific configurations, should we just change them in the beego app.conf? |
stonezdj
approved these changes
Nov 21, 2023
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Nov 22, 2023
1. Increase the default beego max memory and upload size from 32GB to 128GB. 2. Support customize the two beego configs from env. Signed-off-by: chlins <chenyuzh@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Signed-off-by: wang yan <wangyan@vmware.com>
stonezdj
pushed a commit
to stonezdj/harbor
that referenced
this pull request
Dec 5, 2023
1. Increase the default beego max memory and upload size from 32GB to 128GB. 2. Support customize the two beego configs from env. Signed-off-by: chlins <chenyuzh@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com> (cherry picked from commit 553c85e) Signed-off-by: stonezdj <daojunz@vmware.com>
wy65701436
added a commit
that referenced
this pull request
Dec 6, 2023
…#19670) fix: increase beego max memory and upload size (#19578) 1. Increase the default beego max memory and upload size from 32GB to 128GB. 2. Support customize the two beego configs from env. (cherry picked from commit 553c85e) Signed-off-by: chlins <chenyuzh@vmware.com> Signed-off-by: stonezdj <daojunz@vmware.com> Co-authored-by: Chlins Zhang <chenyuzh@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
1. Increase the default beego max memory and upload size from 32GB to 128GB. 2. Support customize the two beego configs from env. Signed-off-by: chlins <chenyuzh@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #18888
Please indicate you've done the following: