Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API(audit-log,project,registry,replication) permission testcase #19584

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Nov 16, 2023

Add audit-log,project,registry,replication API permission testcase

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Add audit-log,project,registry,replication API permission testcase

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #19584 (9c42400) into main (95b4032) will decrease coverage by 22.23%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19584       +/-   ##
===========================================
- Coverage   67.54%   45.32%   -22.23%     
===========================================
  Files         990      244      -746     
  Lines      109060    13323    -95737     
  Branches     2719     2719               
===========================================
- Hits        73670     6038    -67632     
+ Misses      31420     6982    -24438     
+ Partials     3970      303     -3667     
Flag Coverage Δ
unittests 45.32% <ø> (-22.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 748 files with indirect coverage changes

@YangJiao0817 YangJiao0817 merged commit 08cb080 into goharbor:main Nov 16, 2023
14 of 15 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
…oharbor#19584)

Add audit-log,project,registry,replication API permission testcase

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants