add permission validation for robot creating and updating. #19598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wy65701436
added
target/2.10.0
area/robot-account
release-note/update
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19598 +/- ##
=======================================
Coverage 67.52% 67.53%
=======================================
Files 991 991
Lines 109144 109166 +22
Branches 2719 2719
=======================================
+ Hits 73701 73720 +19
- Misses 31474 31475 +1
- Partials 3969 3971 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
force-pushed
the
rb-full-api
branch
2 times, most recently
from
63221db
to
9c66a0f
Compare
stonezdj
approved these changes
Nov 22, 2023
wy65701436
force-pushed
the
rb-full-api
branch
3 times, most recently
from
a67af91
to
0d14b00
Compare
It is not allowed to create an new robot with the access outside the predefined scope. Signed-off-by: wang yan <wangyan@vmware.com>
1. Fix robot testcase 2. update robot permission metadata Signed-off-by: Yang Jiao <jiaoya@vmware.com> Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
force-pushed
the
rb-full-api
branch
from
0d14b00
to
4450200
Compare
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
…19598) * add permission validation for robot creating and updating. It is not allowed to create an new robot with the access outside the predefined scope. Signed-off-by: wang yan <wangyan@vmware.com> * Fix robot testcase and update robot permission metadata (goharbor#167) 1. Fix robot testcase 2. update robot permission metadata Signed-off-by: Yang Jiao <jiaoya@vmware.com> Signed-off-by: wang yan <wangyan@vmware.com> --------- Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: Yang Jiao <jiaoya@vmware.com> Co-authored-by: Yang Jiao <72076317+YangJiao0817@users.noreply.github.com> Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not allowed to create an new robot with the access outside the predefined scope.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: