Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-note/docs] swagger.yaml "repositoryName" parameter description update #19651

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

azsteinb
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

This is a one line change to the swagger.yaml file in order to update the description of the repositoryName parameter. As described in the linked issue, the forward slashes in the repo name parameter need to be double encoded.

Issue being fixed

Fixes #19635

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Aaron Steinberg added 2 commits November 29, 2023 15:51
Signed-off-by: Aaron Steinberg <asteinber-contractor@aurora.tech>
Signed-off-by: Aaron Steinberg <asteinber-contractor@aurora.tech>
@AllForNothing AllForNothing added the release-note/docs Docs changes(made and needed) label Nov 30, 2023
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing enabled auto-merge (squash) November 30, 2023 08:41
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #19651 (ef9d6ba) into main (7cef421) will decrease coverage by 22.19%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19651       +/-   ##
===========================================
- Coverage   67.55%   45.36%   -22.19%     
===========================================
  Files         991      244      -747     
  Lines      109168    13325    -95843     
  Branches     2719     2719               
===========================================
- Hits        73749     6045    -67704     
+ Misses      31451     6979    -24472     
+ Partials     3968      301     -3667     
Flag Coverage Δ
unittests 45.36% <ø> (-22.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

@AllForNothing AllForNothing merged commit 3c56f2d into goharbor:main Nov 30, 2023
12 of 13 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
…on update (goharbor#19651)

* swagger.yaml fix

Signed-off-by: Aaron Steinberg <asteinber-contractor@aurora.tech>

* Signed-off by: Aaron Steinberg <aaron@aa.codes>

Signed-off-by: Aaron Steinberg <asteinber-contractor@aurora.tech>

---------

Signed-off-by: Aaron Steinberg <asteinber-contractor@aurora.tech>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs Docs changes(made and needed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Error Harbor API 2.0, "repositoryName" parameter
5 participants