Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the wording text for the system robot account #19666

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Dec 5, 2023

Update the wording text for the system robot account according to the comments from UX

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #19666 (9cffa14) into main (1cbc901) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 9cffa14 differs from pull request most recent head 5709948. Consider uploading reports for the commit 5709948 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19666      +/-   ##
==========================================
+ Coverage   45.31%   45.36%   +0.05%     
==========================================
  Files         244      244              
  Lines       13331    13331              
  Branches     2719     2719              
==========================================
+ Hits         6041     6048       +7     
+ Misses       6988     6981       -7     
  Partials      302      302              
Flag Coverage Δ
unittests 45.36% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
@AllForNothing AllForNothing merged commit 323e11f into goharbor:main Dec 5, 2023
10 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants