Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min-width to the permission column #19675

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Dec 6, 2023

  1. To avoid style confusion

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #19675 (99dbed5) into main (323e11f) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 99dbed5 differs from pull request most recent head e6aca6c. Consider uploading reports for the commit e6aca6c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19675      +/-   ##
==========================================
- Coverage   67.54%   67.53%   -0.02%     
==========================================
  Files         991      991              
  Lines      109175   109175              
  Branches     2719     2719              
==========================================
- Hits        73746    73735      -11     
- Misses      31461    31469       +8     
- Partials     3968     3971       +3     
Flag Coverage Δ
unittests 67.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

1. To avoid style confusion

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) December 7, 2023 05:01
@YangJiao0817 YangJiao0817 merged commit f99a619 into goharbor:main Dec 7, 2023
10 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. To avoid style confusion

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants