Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the script for tag-retention APIs test case #19676

Closed

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Dec 6, 2023

  1. Make the code logic stronger

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner December 6, 2023 04:51
@AllForNothing AllForNothing added the release-note/infra Infra related changes e.g. release, test, ship etc... label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #19676 (9920e96) into main (323e11f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19676   +/-   ##
=======================================
  Coverage   67.54%   67.54%           
=======================================
  Files         991      991           
  Lines      109175   109175           
  Branches     2719     2719           
=======================================
  Hits        73746    73746           
- Misses      31461    31463    +2     
+ Partials     3968     3966    -2     
Flag Coverage Δ
unittests 67.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

1. Make the code logic stronger

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
@AllForNothing
Copy link
Contributor Author

Dup with #19687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants