Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ip_family config in harbor.yml on release-2.9.0 #19940

Merged

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Feb 2, 2024

Issue being fixed

#19932

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24bbad1) 67.43% compared to head (cd8e913) 67.42%.
Report is 1 commits behind head on release-2.9.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19940      +/-   ##
=================================================
- Coverage          67.43%   67.42%   -0.01%     
=================================================
  Files                993      993              
  Lines             108982   108982              
  Branches            2752     2752              
=================================================
- Hits               73487    73484       -3     
- Misses             31536    31537       +1     
- Partials            3959     3961       +2     
Flag Coverage Δ
unittests 67.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@MinerYang MinerYang force-pushed the add_ipFamily_config_release-2.9 branch 2 times, most recently from 4bc335f to 7936053 Compare February 2, 2024 05:35
Signed-off-by: yminer <yminer@vmware.com>

update name

update prepare and migration

update comments

Signed-off-by: yminer <yminer@vmware.com>

remove print msg

update migrate template

update default value

add validation and migrate template

remove validation

update migrate template comments
@zyyw
Copy link
Contributor

zyyw commented Feb 2, 2024

@MinerYang please see may comment in this PR:

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang changed the title add ip_family config in values.yaml on release-2.9.0 add ip_family config in harbor.yml on release-2.9.0 Feb 2, 2024
@zyyw zyyw merged commit a243bec into goharbor:release-2.9.0 Feb 2, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants