Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two columns to display capability type for scanner #20111

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Add two columns to display capability type for scanner #20111

merged 4 commits into from
Mar 26, 2024

Conversation

xuelichao
Copy link
Contributor

@xuelichao xuelichao commented Mar 9, 2024 •
edited
Loading

Add two columns to display capability type for scanner.
type: sbom | vulnerbility

Issue being fixed

Fixes #(issue)

Screenshot 2024-03-09 at 11 07 51 Screenshot 2024-03-09 at 11 10 32

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao
Add two columns to display capability type for scanner
72d4322 
Signed-off-by: xuelichao <xuel@vmware.com>
@xuelichao xuelichao requested a review from a team as a code owner March 9, 2024 04:13
@xuelichao xuelichao added target/2.11.0 release-note/docs Docs changes(made and needed) labels Mar 9, 2024
Vivekgaddigi
Vivekgaddigi approved these changes Mar 11, 2024
View reviewed changes
Copy link

@Vivekgaddigi Vivekgaddigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wy65701436
wy65701436 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xuelichao
Merge branch 'main' into scanner-sbom
445a5b5 
Signed-off-by: Lichao Xue <68891670+xuelichao@users.noreply.github.com>
@wy65701436 wy65701436 merged commit aa4a142 into goharbor:main Mar 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

@Vivekgaddigi Vivekgaddigi Awaiting requested review from Vivekgaddigi

Assignees

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

@chlins chlins

Labels
release-note/docs Docs changes(made and needed) target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xuelichao @stonezdj @wy65701436 @Vivekgaddigi @OrlinVasilev @chlins