Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scanner tab change #20128

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix: scanner tab change #20128

merged 2 commits into from
Mar 25, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Mar 14, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fix: routing - tc: open image scanners doc page
f88bd18 
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw added release-note/infra Infra related changes e.g. release, test, ship etc... target/2.11.0 labels Mar 14, 2024
@zyyw zyyw requested a review from a team as a code owner March 14, 2024 09:33
@zyyw zyyw changed the title fix: routing - tc: open image scanners doc page fix: scanner tab change Mar 14, 2024
wy65701436
wy65701436 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit fa01cc5 into goharbor:main Mar 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@Vad1mo Vad1mo

@stonezdj stonezdj

@wy65701436 wy65701436

@chlins chlins

@MinerYang MinerYang

Labels
release-note/infra Infra related changes e.g. release, test, ship etc... target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zyyw @stonezdj @wy65701436 @Vad1mo @chlins @MinerYang