fix: panic due to mark retention task error #20137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chlins <chenyuzh@vmware.com>
stonezdj
reviewed
Mar 22, 2024
| @@ -154,11 +154,11 @@ func (c *controller) Start(ctx context.Context, policy *replicationmodel.Policy, | |||
| func (c *controller) markError(ctx context.Context, executionID int64, err error) { | |||
| logger := log.GetLogger(ctx) | |||
| // try to stop the execution first in case that some tasks are already created | |||
| if err := c.execMgr.StopAndWait(ctx, executionID, 10*time.Second); err != nil { | |||
| logger.Errorf("failed to stop the execution %d: %v", executionID, err) | |||
| if stopErr := c.execMgr.StopAndWait(ctx, executionID, 10*time.Second); stopErr != nil { | |||
There was a problem hiding this comment.
Because the code change is related to execMgr, is it possible to extract a function and move it to execMgr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify err assignment to prevent panic caused by overwriting.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #20129
Please indicate you've done the following: