delete membership=0 in getProjectsByName

[prima101112]

delete membership=0 in getProjectsByName but lets getProjects still using membership=1 for reserve if getProjectsByName not found any

Comprehensive Summary of your change

Issue being fixed

Fixes #20056

Please indicate you've done the following:

• Well Written Title and Summary of the PR
• Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
• Accepted the DCO. Commits without the DCO will delay acceptance.
• Made sure tests are passing and test coverage is added if needed.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

[stonezdj]

LGTM

[stonezdj]

@prima101112 could you please give us the document link for it?

[chlins]

@lxShaDoWxl Kindly review this, thank you!

[prima101112]

@prima101112 could you please give us the document link for it?

whats document, is this whay you mean https://docs.gitlab.com/ee/api/projects.html
from the issue just state that when using public gitlab it should not require the member of the project

please assist me if its missing something or need to be fixed

[lxShaDoWxl]

you can also remove the "membership" here, only the search becomes more extensive. The disadvantage is only in performance

[prima101112]

you can also remove the "membership" here, only the search becomes more extensive. The disadvantage is only in performance

I think yes we can remove the "membership" but adjusting the fallback mechanism is risky. Currently, if the repository is not found, the search extends to the entire GitLab instance. However, it would be more efficient to limit the search to projects where the user is a member. This way, the search would only include projects that the user has access to. so i will leave it like that. please advice

[prima101112]

@lxShaDoWxl could we get approval for this

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.35%. Comparing base (b7b8847) to head (a28da8b).
Report is 112 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #20153       +/-   ##
===========================================
- Coverage   67.56%   45.35%   -22.22%     
===========================================
  Files         991      244      -747     
  Lines      109181    13345    -95836     
  Branches     2719     2724        +5     
===========================================
- Hits        73768     6052    -67716     
+ Misses      31449     6991    -24458     
+ Partials     3964      302     -3662     

Flag	Coverage Δ
unittests	45.35% <ø> (-22.22%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1235 files with indirect coverage changes