Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt cosign with oci-spec 1.1 #20245

Merged

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang requested a review from a team as a code owner April 8, 2024 09:46
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.58%. Comparing base (b7b8847) to head (4f26af6).
Report is 122 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20245      +/-   ##
==========================================
+ Coverage   67.56%   67.58%   +0.02%     
==========================================
  Files         991     1002      +11     
  Lines      109181   110463    +1282     
  Branches     2719     2781      +62     
==========================================
+ Hits        73768    74660     +892     
- Misses      31449    31789     +340     
- Partials     3964     4014      +50     
Flag Coverage Δ
unittests 67.58% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/middleware/cosign/cosign.go 55.40% <ø> (ø)
src/server/middleware/subject/subject.go 47.61% <0.00%> (-0.87%) ⬇️

... and 517 files with indirect coverage changes

Signed-off-by: yminer <yminer@vmware.com>

add comment for cosign middlware
@MinerYang MinerYang force-pushed the update_subject_middleware_for_cosign branch from 5ad1919 to 714ad8c Compare April 9, 2024 08:29
@MinerYang MinerYang assigned wy65701436 and unassigned Vad1mo and AllForNothing Apr 9, 2024
@MinerYang MinerYang changed the title [DRAFT]adopt cosign with oci-spec 1.1 adopt cosign with oci-spec 1.1 Apr 9, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 2bb5166 into goharbor:main Apr 10, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants