Add generate SBOM feature #20251
Merged
Add generate SBOM feature #20251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
c2c1d71
to
5db3966
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20251 +/- ##
===========================================
- Coverage 67.56% 46.10% -21.47%
===========================================
Files 991 246 -745
Lines 109181 13565 -95616
Branches 2719 2781 +62
===========================================
- Hits 73768 6254 -67514
+ Misses 31449 6995 -24454
+ Partials 3964 316 -3648
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
7 times, most recently
from
459625f
to
a77403d
Compare
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
d66f9a6
to
9f5488e
Compare
wy65701436
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
zyyw
reviewed
Apr 15, 2024
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
2 times, most recently
from
30fc819
to
7d278d8
Compare
zyyw
reviewed
Apr 15, 2024
zyyw
reviewed
Apr 15, 2024
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
7d278d8
to
7a05b93
Compare
xuelichao
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
7a05b93
to
5906bb0
Compare
wy65701436
reviewed
Apr 15, 2024
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
5906bb0
to
4a559c2
Compare
wy65701436
reviewed
Apr 15, 2024
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
4a559c2
to
2344959
Compare
wy65701436
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
wy65701436
reviewed
Apr 15, 2024
| @@ -38,7 +38,14 @@ func GetScanHandler(requestType string) Handler { | |||
|
|
|||
| // Handler handler for scan job, it could be implement by different scan type, such as vulnerability, sbom | |||
| type Handler interface { | |||
There was a problem hiding this comment.
TODO, refactor this interface, it's now acts as a facade, rather than a interface.
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
3 times, most recently
from
4b21645
to
83a9cbe
Compare
zyyw
approved these changes
Apr 16, 2024
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
83a9cbe
to
b29122e
Compare
Add scan handler for sbom Delete previous sbom accessory before the job service Signed-off-by: stonezdj <daojunz@vmware.com>
stonezdj
force-pushed
the
24mar28_add_sbom_scan
branch
from
88fc465
to
10dd4cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: