Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SBOM icon #20270

Merged
merged 1 commit into from
Apr 12, 2024
Merged

add SBOM icon #20270

merged 1 commit into from
Apr 12, 2024

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang added release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0 labels Apr 12, 2024
@MinerYang MinerYang requested a review from a team as a code owner April 12, 2024 07:51
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.40%. Comparing base (b7b8847) to head (e420303).
Report is 130 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20270      +/-   ##
==========================================
- Coverage   67.56%   66.40%   -1.16%     
==========================================
  Files         991     1039      +48     
  Lines      109181   112536    +3355     
  Branches     2719     2781      +62     
==========================================
+ Hits        73768    74732     +964     
- Misses      31449    33778    +2329     
- Partials     3964     4026      +62     
Flag Coverage Δ
unittests 66.40% <ø> (-1.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/icon/controller.go 60.93% <ø> (ø)
src/pkg/accessory/manager.go 83.69% <ø> (ø)

... and 559 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 7465a29 into goharbor:main Apr 12, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants