Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19928 #20409

Merged
merged 7 commits into from
May 15, 2024

Merge branch 'main' into fix-19928

60044f1
Select commit
Loading
Failed to load commit list.
Merged

fix issue 19928 #20409

Merge branch 'main' into fix-19928
60044f1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 14, 2024 in 0s

66.36% (-1.20%) compared to b7b8847

View this Pull Request on Codecov

66.36% (-1.20%) compared to b7b8847

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.36%. Comparing base (b7b8847) to head (60044f1).
Report is 182 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20409      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.20%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113132    +3951     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75084    +1316     
- Misses      31449    33984    +2535     
- Partials     3964     4064     +100     
Files Coverage Δ
src/common/rbac/project/rbac_role.go 70.00% <ø> (ø)
src/controller/member/controller.go 21.15% <100.00%> (ø)
src/pkg/cached/project/redis/manager.go 55.69% <0.00%> (ø)
src/pkg/project/manager.go 5.26% <0.00%> (ø)
src/pkg/project/dao/dao.go 70.83% <86.36%> (+7.05%) ⬆️
src/server/v2.0/handler/permissions.go 0.00% <0.00%> (ø)

... and 566 files with indirect coverage changes