Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix 20496 #20509

Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 29, 2024

fixes #20496

Harbor will reserve one SBOM accessory artifact for each subject artifact. Ensure all existing SBOMs are removed before generating the next set.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fixes goharbor#20496

Harbor will reserve one SBOM accessory artifact for each subject artifact. Ensure all existing SBOMs are removed before generating the next set.

Signed-off-by: wang yan <wangyan@vmware.com>

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 requested a review from a team as a code owner May 29, 2024 06:49
@wy65701436 wy65701436 changed the title fix 20496 [cherry-pick] fix 20496 May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-2.11.0@14f9af0). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20509   +/-   ##
=================================================
  Coverage                  ?   66.23%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113463           
  Branches                  ?     2842           
=================================================
  Hits                      ?    75155           
  Misses                    ?    34204           
  Partials                  ?     4104           
Flag Coverage Δ
unittests 66.23% <63.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/sbom.go 52.72% <63.63%> (ø)

@wy65701436 wy65701436 merged commit 723abc6 into goharbor:release-2.11.0 May 29, 2024
14 of 15 checks passed
wy65701436 added a commit to wy65701436/harbor that referenced this pull request May 29, 2024
fix 20496

fixes goharbor#20496

Harbor will reserve one SBOM accessory artifact for each subject artifact. Ensure all existing SBOMs are removed before generating the next set.

Signed-off-by: wang yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants