Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix http client to push sbom accessory #20528

Merged
merged 1 commit into from
May 31, 2024

Conversation

wy65701436
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 requested a review from a team as a code owner May 31, 2024 07:38
@wy65701436 wy65701436 changed the title fix http client to push sbom accessory [cherry-pick] fix http client to push sbom accessory May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@9944059). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20528   +/-   ##
=================================================
  Coverage                  ?   66.25%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113477           
  Branches                  ?     2844           
=================================================
  Hits                      ?    75179           
  Misses                    ?    34189           
  Partials                  ?     4109           
Flag Coverage Δ
unittests 66.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/util.go 64.00% <100.00%> (ø)

@stonezdj stonezdj merged commit eeec103 into goharbor:release-2.11.0 May 31, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants