Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for ldap group sync in background #20672

Closed
wants to merge 1 commit into from

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jun 27, 2024

for better performance with large amount of ldap group

UI change in LDAP configuration: add a configuration item in LDAP Group Sync in Background
Screenshot 2024-06-27 at 18 07 05

The screenshot is the compare between the sync group in background and sync group at login, with 1000 user groups and slow response ldap server, it will exceed 60 sec and timeout., when the sync group in background is true, the login is fast.

Screenshot 2024-06-27 at 16 54 34

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 27, 2024 09:06
@stonezdj stonezdj requested review from wy65701436 and zyyw June 27, 2024 09:16
@stonezdj stonezdj added release-note/update Update or Fix release-note/enhancement Label to mark PR to be added under release notes as enhancement and removed release-note/update Update or Fix labels Jun 27, 2024
@stonezdj stonezdj changed the title Add configuration for ldap group sync in background [WIP]Add configuration for ldap group sync in background Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.79365% with 31 lines in your changes missing coverage. Please review.

Project coverage is 69.01%. Comparing base (b7b8847) to head (5797279).
Report is 233 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20672      +/-   ##
==========================================
+ Coverage   67.56%   69.01%   +1.44%     
==========================================
  Files         991      798     -193     
  Lines      109181    99788    -9393     
  Branches     2719        0    -2719     
==========================================
- Hits        73768    68866    -4902     
+ Misses      31449    27130    -4319     
+ Partials     3964     3792     -172     
Flag Coverage Δ
unittests 69.01% <50.79%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/config/models/model.go 100.00% <ø> (ø)
src/lib/config/userconfig.go 66.88% <100.00%> (-1.10%) ⬇️
src/pkg/usergroup/manager.go 55.26% <33.33%> (+0.59%) ⬆️
src/core/auth/ldap/ldap.go 53.46% <51.78%> (+6.63%) ⬆️

... and 324 files with indirect coverage changes

@stonezdj stonezdj changed the title [WIP]Add configuration for ldap group sync in background Add configuration for ldap group sync in background Jun 27, 2024
 for better performance with large amount of ldap group

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj requested review from AllForNothing and reasonerjt and removed request for AllForNothing June 28, 2024 02:39
@stonezdj stonezdj requested a review from xuelichao June 28, 2024 02:41
@stonezdj stonezdj closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants