Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the API data for the dependencies of the helm chart #20676

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 28, 2024

Fix the handle logic of the chart operator, correct the data for the dependencies of the helm chart.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20675

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix the handle logic of the chart operator, correct the data for the
dependencies of the helm chart.

Signed-off-by: chlins <chlins.zhang@gmail.com>
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.23%. Comparing base (b7b8847) to head (3ed1ef8).
Report is 233 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20676      +/-   ##
==========================================
- Coverage   67.56%   66.23%   -1.33%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113501    +4320     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75181    +1413     
- Misses      31449    34210    +2761     
- Partials     3964     4110     +146     
Flag Coverage Δ
unittests 66.23% <53.84%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/chart/operator.go 62.12% <53.84%> (-2.70%) ⬇️

... and 600 files with indirect coverage changes

@chlins chlins added the release-note/update Update or Fix label Jun 28, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 7ffc378 into goharbor:main Jul 1, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not display the dependencies of the helm chart
6 participants