Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel attach ldap group #20705

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jul 5, 2024

Add configure LDAP group attach parallel UI
Change the /c/login timeout from 60 (nginx default) to 900 seconds in nginx.conf

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner July 5, 2024 02:29
@stonezdj stonezdj requested a review from reasonerjt July 5, 2024 02:29
@stonezdj stonezdj requested a review from wy65701436 July 5, 2024 02:30
@stonezdj stonezdj added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jul 5, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 8.45070% with 65 lines in your changes missing coverage. Please review.

Project coverage is 66.25%. Comparing base (c8c11b4) to head (322bff2).
Report is 253 commits behind head on main.

Files Patch % Lines
src/core/auth/ldap/ldap.go 7.14% 61 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20705       +/-   ##
===========================================
+ Coverage   45.36%   66.25%   +20.88%     
===========================================
  Files         244     1046      +802     
  Lines       13333   114127   +100794     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75610    +69561     
- Misses       6983    34395    +27412     
- Partials      301     4122     +3821     
Flag Coverage Δ
unittests 66.25% <8.45%> (+20.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/config/models/model.go 100.00% <ø> (ø)
src/lib/config/userconfig.go 66.88% <100.00%> (ø)
src/core/auth/ldap/ldap.go 37.45% <7.14%> (ø)

... and 1284 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24jul01_ldap_group_perf branch 3 times, most recently from ee269fc to 88dc5bc Compare July 8, 2024 05:27
api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  Add configure LDAP group attach parallel UI
  Change the /c/login timeout from 60 (nginx default) to 900 seconds in nginx.conf

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj enabled auto-merge (squash) August 9, 2024 07:07
@stonezdj stonezdj merged commit eb5193e into goharbor:main Aug 9, 2024
11 of 12 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
Parallel attach LDAP group

  Add configure LDAP group attach parallel UI
  Change the /c/login timeout from 60 (nginx default) to 900 seconds in nginx.conf

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants