Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable robot full access #20754

Merged
merged 3 commits into from
Sep 26, 2024
Merged

enable robot full access #20754

merged 3 commits into from
Sep 26, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 18, 2024

When the system admin enable this option, the robot can be assigned with robot/user/group/quota permissions.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner July 18, 2024 06:42
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 19.02174% with 149 lines in your changes missing coverage. Please review.

Project coverage is 66.63%. Comparing base (c8c11b4) to head (9ce12fa).
Report is 283 commits behind head on main.

Files with missing lines Patch % Lines
src/server/v2.0/handler/robot.go 23.72% 90 Missing ⚠️
src/common/rbac/const.go 10.20% 44 Missing ⚠️
src/controller/robot/controller.go 0.00% 12 Missing ⚠️
src/server/v2.0/handler/permissions.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20754       +/-   ##
===========================================
+ Coverage   45.36%   66.63%   +21.26%     
===========================================
  Files         244     1048      +804     
  Lines       13333   114443   +101110     
  Branches     2719     2850      +131     
===========================================
+ Hits         6049    76260    +70211     
- Misses       6983    34292    +27309     
- Partials      301     3891     +3590     
Flag Coverage Δ
unittests 66.63% <19.02%> (+21.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/controller/robot/model.go 100.00% <ø> (ø)
src/controller/scan/base_controller.go 56.98% <100.00%> (ø)
src/server/v2.0/handler/permissions.go 0.00% <0.00%> (ø)
src/controller/robot/controller.go 56.18% <0.00%> (ø)
src/common/rbac/const.go 10.20% <10.20%> (ø)
src/server/v2.0/handler/robot.go 11.71% <23.72%> (ø)

... and 1282 files with indirect coverage changes

src/common/const.go Outdated Show resolved Hide resolved
src/common/rbac/const.go Outdated Show resolved Hide resolved
src/common/rbac/const.go Outdated Show resolved Hide resolved
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

When the system admin enable this option, the robot can be assigned with robot/user/group/quota permissions.

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 changed the title have option to enable robot full access enable robot full access Sep 25, 2024
@wy65701436 wy65701436 added release-note/new-feature New Harbor Feature and removed DONT MERGE release-note/update Update or Fix labels Sep 25, 2024
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 force-pushed the robot-acc branch 5 times, most recently from f3e7cb3 to 6f207d8 Compare September 26, 2024 07:11
Update codes according to the proposal of goharbor/community#249

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 merged commit e4fe61d into goharbor:main Sep 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants