Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Check create when fire the artifact event #20838

Merged

Conversation

stonezdj
Copy link
Contributor

fixes #20828

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  fixes goharbor#20828

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@ff3e16a). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20838   +/-   ##
=================================================
  Coverage                  ?   66.31%           
=================================================
  Files                     ?     1044           
  Lines                     ?   113927           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75546           
  Misses                    ?    34262           
  Partials                  ?     4119           
Flag Coverage Δ
unittests 66.31% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/artifact/controller.go 62.30% <100.00%> (ø)

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit a0d4092 into goharbor:release-2.11.0 Aug 12, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants