Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Updated Docs #412

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Feat: Updated Docs #412

merged 8 commits into from
Mar 4, 2024

Conversation

a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Feb 10, 2024

This PR is to bring the docs into line with the recommended style from hashicorp, using their tool tfplugindocs

I tried to keep the docs feeling mostly the same well being within "spec", please let me know if any of the new docs are out of date. I mostly tried to keep what was still valid arguments and the descriptions for those arguments.

@a1994sc a1994sc requested a review from a team as a code owner February 10, 2024 16:15
@Vad1mo
Copy link
Member

Vad1mo commented Feb 11, 2024

@a1994sc thank you for your contribution. this is great.
Is there a need or option to automate things, with eg. gh action or is it a one time manual thing?

@a1994sc
Copy link
Contributor Author

a1994sc commented Feb 11, 2024

No problem to all! As for actions I am not too sure, that part is something that I have not dug to much into, but I did find this which seems to be a step in the right direction.

@a1994sc
Copy link
Contributor Author

a1994sc commented Feb 11, 2024

So I used the command tfplugindocs at the root of the repo to get all the files generated from the templates/*.tmpl files.

Edit: Sorry realized I removed the helm arg from the doc file and not the template.

Signed-off-by: Allen Conlon <allen@conlon.dev>
Signed-off-by: Allen Conlon <allen@conlon.dev>
Signed-off-by: Allen Conlon <allen@conlon.dev>
Signed-off-by: Allen Conlon <allen@conlon.dev>
Signed-off-by: Allen Conlon <allen@conlon.dev>
@a1994sc
Copy link
Contributor Author

a1994sc commented Feb 17, 2024

@Vad1mo did you have any questions?

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great

@a1994sc
Copy link
Contributor Author

a1994sc commented Feb 21, 2024

Is the failing build, sonarcloud, something I should worry about?

@flbla
Copy link
Contributor

flbla commented Feb 28, 2024

Hi,
@a1994sc, thank you! It looks great!
I agree with @Vad1mo, It would be even better if we could implement a gh action
I'm concerned that I might forget to update the template and launch the CLI every time an update is made to the documentation.

@flbla
Copy link
Contributor

flbla commented Feb 28, 2024

maybe a gh action executed on pull request

@a1994sc
Copy link
Contributor Author

a1994sc commented Feb 28, 2024

@flbla so taking a look at what hashicorp does it seem they regenerate the docs: link , make

So I can add a similar action if you would like.

@flbla
Copy link
Contributor

flbla commented Feb 28, 2024

it seems good!
let me know if you need help
thank you!

Signed-off-by: Allen Conlon <allen@conlon.dev>
Signed-off-by: Allen Conlon <allen@conlon.dev>
@a1994sc
Copy link
Contributor Author

a1994sc commented Feb 28, 2024

@flbla Added a new action and it works locally can you let me know what you think?

@a1994sc
Copy link
Contributor Author

a1994sc commented Feb 28, 2024

I also only added the make setting for generating the docs, idk enough on the setup of this project, and golang in general, to do that lol

@a1994sc
Copy link
Contributor Author

a1994sc commented Mar 1, 2024

@Vad1mo I will try to debug why that action is failing... Thanks for the approval!

Signed-off-by: Allen Conlon <allen@conlon.dev>
@a1994sc a1994sc requested a review from flbla March 4, 2024 01:43
Copy link
Contributor

@flbla flbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flbla flbla merged commit cb9cdb2 into goharbor:main Mar 4, 2024
11 of 12 checks passed
@flbla
Copy link
Contributor

flbla commented Mar 4, 2024

@a1994sc : thank you 👍

@a1994sc a1994sc deleted the feature/update-docs branch March 4, 2024 14:49
@a1994sc
Copy link
Contributor Author

a1994sc commented Mar 4, 2024

@flbla No problem! Glad to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants