Enhance the explanation for the group filter #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AllForNothing
commented
Oct 26, 2023
AllForNothing
commented
- Fixes OIDC OnBoarding - Group Filter not working harbor#19419
| - **OIDC Provider Name**: The name of the OIDC provider. | ||
| - **OIDC Provider Endpoint**: The URL of the endpoint of the OIDC provider. | ||
| - **OIDC Client ID**: The client ID with which Harbor is registered as client application with the OIDC provider. | ||
| - **OIDC Client Secret**: The secret for the Harbor client application. | ||
| - **OIDC Group Filter**: The [regular expression](https://pkg.go.dev/regexp/syntax) to filter OIDC groups.Only the groups that match the provided regular express will be added to Harbor. | ||
| - **OIDC Group Filter**: The [regular expression](https://pkg.go.dev/regexp/syntax) to filter OIDC groups.Only the groups that match the provided regular express will be added to Harbor. It only filter the groups, doesn’t limit the users login to Harbor. |
There was a problem hiding this comment.
Suggested change
| - **OIDC Group Filter**: The [regular expression](https://pkg.go.dev/regexp/syntax) to filter OIDC groups.Only the groups that match the provided regular express will be added to Harbor. It only filter the groups, doesn’t limit the users login to Harbor. | |
| - **OIDC Group Filter**: The [regular expression](https://pkg.go.dev/regexp/syntax) to filter OIDC groups.Only the groups that match the provided regular express will be added to Harbor. It only filters the groups and doesn’t limit the user's login to Harbor. |
|
@AllForNothing added comment |
Vad1mo
requested changes
Oct 26, 2023
There was a problem hiding this comment.
The whole text is a bit off:
It misses:
- On what data/source it is filtering on? -> «Group Claim Name»
- What will happen with the filtered result -> Groups are added to Harbor
What about this:
OIDC Group Filter: A regular expression to select matching groups from the «Group Claim Name» list
. Matching groups are added to Harbor. This filter does not limit the users' capability to log in into Harbor.
|
@Vad1mo Thanks for the commend, will update the PR later. |
1. Fix goharbor/harbor#19419 Signed-off-by: AllForNothing <sshijun@vmware.com>
OrlinVasilev
approved these changes
Oct 27, 2023
Vad1mo
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.