Fallback to showing UID/GID if user/group lookup fails #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelim-work
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
This sounds like a reasonable idea, thanks for the contribution!
BTW you can factor out the fmt.Sprintf call like below, but I don't mind either way:
uid := fmt.Sprint(stat.Uid)
if u, err := user.LookupId(uid); err == nil {
return u.Username
} else {
return uid
}
If you mount a filesystem from another computer then UID/GID might not be mapped to any user. This changes it so that lf shows the UID and GID instead of nothing if user/group lookup fails.
|
It looks good. Thank you @jantatje for the patch and @joelim-work for the review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you mount a filesystem from another computer then UID/GID might not be mapped to any user. This changes it so that lf shows the UID and GID instead of nothing if user/group lookup fails.