Skip to content

Commit

Permalink
ssh: disable client agent tests on Windows
Browse files Browse the repository at this point in the history
ssh-agent is implemented as a Windows service and exposed on a
named pipe. We don't currently support it.

See golang/go#60981

Change-Id: Iebdc42db30b37a87ac0766231b16aff3f17b3f56
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/509035
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
  • Loading branch information
drakkan authored and gopherbot committed Jul 13, 2023
1 parent 2e82bdd commit 5df3b59
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ssh/agent/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ func startOpenSSHAgent(t *testing.T) (client ExtendedAgent, socket string, clean
// types supported vary by platform.
t.Skip("skipping test due to -short")
}
if runtime.GOOS == "windows" {
t.Skip("skipping on windows, we don't support connecting to the ssh-agent via a named pipe")
}

bin, err := exec.LookPath("ssh-agent")
if err != nil {
Expand Down

0 comments on commit 5df3b59

Please sign in to comment.