Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chacha20: Allow reinitialisation of existing chacha20 structure #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

u1f35c
Copy link

@u1f35c u1f35c commented Feb 20, 2021

Rather than requiring a new memory allocation for every use of the
chacha20 primitive allow an existing chacha20.Cipher to be reinitialised
with a new key + nonce. This can help avoid allocations in hot paths.

Fixes golang/go#44449

Rather than requiring a new memory allocation for every use of the
chacha20 primitive allow an existing chacha20.Cipher to be reinitialised
with a new key + nonce. This can help avoid allocations in hot paths.

Fixes golang/go#44449
@google-cla google-cla bot added the cla: yes label Feb 20, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 0bcc0cb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/294649 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/294649.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants