New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding new key wrap support as per rfc 3394 and 5649 #49

Open

rajnikant12345 wants to merge 1 commit into golang:master from rajnikant12345:master

+378 −0

rajnikant12345 commented May 30, 2018

i am closing pull request 46, because i have lost track of changes.


          adding new key wrap support. Lost the last changes

ae14f15

googlebot added the cla: yes label

Author

rajnikant12345 commented May 30, 2018

By mistake i deleted the fork of my last pull reuest i.e. 46. So this is a new one.

Contributor

gopherbot commented May 30, 2018

This PR (HEAD: ae14f15) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/crypto/+/115336 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Feb 6, 2019

Message from Andrew Bonventre:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 7, 2019

Message from rajni kant:

Patch Set 1:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

No corresponding issue, this is the feature we needed in our crypto application which was build using GO. I thought it will be good to add this to Go crypto.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 7, 2019

Message from Andrew Bonventre:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 8, 2019

Message from rajni kant:

Patch Set 1:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

golang/go#30128

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch from 4663e18 to 8834368 Compare

October 1, 2019 14:10

Contributor

gopherbot commented Nov 8, 2021

Message from Andrew Bonventre:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 8, 2021

Message from rajni kant:

Patch Set 1:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

No corresponding issue, this is the feature we needed in our crypto application which was build using GO. I thought it will be good to add this to Go crypto.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 8, 2021

Message from Andrew Bonventre:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 8, 2021

Message from rajni kant:

Patch Set 1:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

golang/go#30128

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Andrew Bonventre:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from rajni kant:

Patch Set 1:

Patch Set 1:

(2 comments)

Is there a corresponding issue discussing this change?

No corresponding issue, this is the feature we needed in our crypto application which was build using GO. I thought it will be good to add this to Go crypto.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Andrew Bonventre:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from rajni kant:

Patch Set 1:

Patch Set 1:

Please file an issue as it's a non-trivial amount of code and introducing new exported functions per https://golang.org/doc/contribute.html#design

Thanks.

golang/go#30128

Please don’t reply on this GitHub thread. Visit golang.org/cl/115336.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels