Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme/autocert: Enable custom ports #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

axxelG
Copy link

@axxelG axxelG commented Dec 26, 2018

It is mandatory to be reachable on port 443 from the public internet but it is completely fine to run a service on a different port internally and use e. g. NAT/masquerading.

Additionally I might want to bind a service not to all of my local IP addresses.

Fixes issue #29540

@gopherbot
Copy link
Contributor

This PR (HEAD: 5dd1a0f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/155744 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Katie Hockman:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Katie Hockman:

Patch Set 1:

Since this is a non-trivial change, please associate this change with an issue that describes the decision from the code owners. If possible, please also include/update any tests.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: f77e8f7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/155744 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Axel Gluth:

Patch Set 3:

(1 comment)

Reply to comments


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

jandd pushed a commit to jandd/crypto that referenced this pull request Jun 26, 2021
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Katie Hockman:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c5d131a


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Katie Hockman:

Patch Set 1:

Since this is a non-trivial change, please associate this change with an issue that describes the decision from the code owners. If possible, please also include/update any tests.


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Axel Gluth:

Patch Set 3:

(1 comment)

Reply to comments


Please don’t reply on this GitHub thread. Visit golang.org/cl/155744.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants