Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key type in NewDSAPublicKey doc. #7

Closed
wants to merge 1 commit into from

Conversation

atomatt
Copy link

@atomatt atomatt commented Jul 3, 2015

No description provided.

@agl
Copy link
Contributor

agl commented Jul 3, 2015

We don't take pull requests I'm afraid—GitHub is just a mirror when it comes to source code.

Since GitHub doesn't enforce that submitters have signed the CLA either, I don't want to look at the patch for copyright reasons. If you would like to submit the patch, please see https://golang.org/doc/contribute.html. However, if you don't plan on it being a regular thing and don't wish to bother with that, just say so and I'll consider this a bug report. I'm sure that I can find the error given the above function name.

@agl agl closed this Jul 3, 2015
@atomatt
Copy link
Author

atomatt commented Jul 3, 2015

Not worth signing the CLA for this so consider it a bug report - problem is just that it says "rsa" instead of "dsa" in the func's doc.

@agl
Copy link
Contributor

agl commented Jul 4, 2015

Thanks, I believe that I found the issue based on your description: https://go.googlesource.com/crypto/+/2f677ffe0a128ed6d4e3ecb565e4d29a6c6365da

Alkorin pushed a commit to Alkorin/crypto that referenced this pull request May 10, 2018
openpgp: ignore out-of-place signatures on subkeys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants