Disable revision validation, for now

Too much complexity and too much performance hit for pretty marginal
benefit, at least for MVP.

satisfy.go

@@ -41,10 +41,12 @@ func (s *solver) checkProject(a atomWithPackages) error {
 			s.logSolve(err)
 			return err
 		}
-		if err := s.checkRevisionExists(a, dep); err != nil {
-			s.logSolve(err)
-			return err
-		}
+		// TODO decide how to refactor in order to re-enable this. Checking for
+		// revision existence is important...but kinda obnoxious.
+		//if err := s.checkRevisionExists(a, dep); err != nil {
+		//s.logSolve(err)
+		//return err
+		//}
 		if err := s.checkPackageImportsFromDepExist(a, dep); err != nil {
 			s.logSolve(err)
 			return err
@@ -88,10 +90,12 @@ func (s *solver) checkPackage(a atomWithPackages) error {
 			s.logSolve(err)
 			return err
 		}
-		if err := s.checkRevisionExists(a, dep); err != nil {
-			s.logSolve(err)
-			return err
-		}
+		// TODO decide how to refactor in order to re-enable this. Checking for
+		// revision existence is important...but kinda obnoxious.
+		//if err := s.checkRevisionExists(a, dep); err != nil {
+		//s.logSolve(err)
+		//return err
+		//}
 		if err := s.checkPackageImportsFromDepExist(a, dep); err != nil {
 			s.logSolve(err)
 			return err

solve_basic_test.go

@@ -898,30 +898,32 @@ var basicFixtures = []basicFixture{
 			"foo r123abc",
 		),
 	},
-	{
-		// Solve fails if revision constraint calls for a nonexistent revision
-		n: "fail on missing revision",
-		ds: []depspec{
-			mkDepspec("root 0.0.0", "bar *"),
-			mkDepspec("bar 1.0.0", "foo r123abc"),
-			mkDepspec("foo r123nomatch"),
-			mkDepspec("foo 1.0.0"),
-			mkDepspec("foo 2.0.0"),
-		},
-		errp: []string{"bar", "foo", "bar"},
-	},
-	{
-		// Solve fails if revision constraint calls for a nonexistent revision,
-		// even if rev constraint is specified by root
-		n: "fail on missing revision from root",
-		ds: []depspec{
-			mkDepspec("root 0.0.0", "foo r123nomatch"),
-			mkDepspec("foo r123abc"),
-			mkDepspec("foo 1.0.0"),
-			mkDepspec("foo 2.0.0"),
-		},
-		errp: []string{"foo", "root", "foo"},
-	},
+	// TODO decide how to refactor the solver in order to re-enable these.
+	// Checking for revision existence is important...but kinda obnoxious.
+	//{
+	//// Solve fails if revision constraint calls for a nonexistent revision
+	//n: "fail on missing revision",
+	//ds: []depspec{
+	//mkDepspec("root 0.0.0", "bar *"),
+	//mkDepspec("bar 1.0.0", "foo r123abc"),
+	//mkDepspec("foo r123nomatch"),
+	//mkDepspec("foo 1.0.0"),
+	//mkDepspec("foo 2.0.0"),
+	//},
+	//errp: []string{"bar", "foo", "bar"},
+	//},
+	//{
+	//// Solve fails if revision constraint calls for a nonexistent revision,
+	//// even if rev constraint is specified by root
+	//n: "fail on missing revision from root",
+	//ds: []depspec{
+	//mkDepspec("root 0.0.0", "foo r123nomatch"),
+	//mkDepspec("foo r123abc"),
+	//mkDepspec("foo 1.0.0"),
+	//mkDepspec("foo 2.0.0"),
+	//},
+	//errp: []string{"foo", "root", "foo"},
+	//},
 
 	// TODO add fixture that tests proper handling of loops via aliases (where
 	// a project that wouldn't be a loop is aliased to a project that is a loop)