This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
internal/gps: parallelize WriteDepTree #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates WriteDepTree to parallelize write projects to the vendor directory. Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
ibrasho
force-pushed
the
parallelize-WriteDepTree
branch
from
1fa8a51
to
87bf819
Compare
|
Running I tried |
jmank88
approved these changes
Aug 16, 2017
sdboyer
approved these changes
Aug 17, 2017
|
wow, that's way more of an improvement than i'd expected. spectacular! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This commit updates WriteDepTree to parallelize write projects to the
vendor directory.
This change gives a decent speed boost when writing
vendordirectory.What should your reviewer look out for in this PR?
Correctness.
Which issue(s) does this PR fix?
This somehow became part of #952 even though it's not really related. 😁