This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
gps: include output in error #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
reviewed
Sep 19, 2017
| @@ -21,41 +21,33 @@ type cmd struct { | |||
| ctx context.Context | |||
| // cancel is called when the graceful shutdown timeout expires. | |||
| cancel context.CancelFunc | |||
| cmd *exec.Cmd | |||
| Cmd *exec.Cmd | |||
There was a problem hiding this comment.
Why is this field being exported?
There was a problem hiding this comment.
So that cmd.go can compile. The windows variant embeds this field directly.
jmank88
approved these changes
Sep 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Includes a command's stderr in the error string. I was seeing SSL errors with one of my dependencies, and the missing error information was quite annoying.
What should your reviewer look out for in this PR?
Nothing special.
Do you need help or clarification on anything?
No.
Which issue(s) does this PR fix?
None.