This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
cmd/dep: make out-of-sync ensure less strict #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibrasho you wanna take review on this one? |
ibrasho
reviewed
Oct 1, 2017
| @@ -479,7 +477,7 @@ func (cmd *ensureCommand) runAdd(ctx *dep.Ctx, args []string, p *dep.Project, sm | |||
|
|
|||
| var wg sync.WaitGroup | |||
|
|
|||
| fmt.Println("Fetching sources...") | |||
| ctx.Out.Println("Fetching sources...") | |||
zknill
pushed a commit
to zknill/dep
that referenced
this pull request
Oct 6, 2017
* cmd/dep: make out-of-sync ensure less strict * cmd/dep: fix broken integration test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This change makes ensure less strict when out-of-sync allowing execution to continue. Removed mention of
Run "dep ensure" to resync them first before running "dep ensure -update"since this is not necessary anymore.Do you need help or clarification on anything?
Please let know if
ctx.Err.Printfshould be use in this case orctx.Out.Printfis fine.Which issue(s) does this PR fix?
fixes #1126