Skip to content

Commit

Permalink
cmd/go/internal/renameio: skip test affected by kernel bug on macOS 1…
Browse files Browse the repository at this point in the history
…0.14 builders

The test will remain flaky on the -nocgo builder until #37695 is addressed.

Updates #37695
Fixes #33041

Change-Id: I5d661ef39e82ab1dce3a76e0e4059cf556135e89
Reviewed-on: https://go-review.googlesource.com/c/go/+/222158
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
  • Loading branch information
Bryan C. Mills committed Mar 5, 2020
1 parent 55d4cbf commit 4a70ff4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/cmd/go/internal/renameio/renameio_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ package renameio
import (
"encoding/binary"
"errors"
"internal/testenv"
"io/ioutil"
"math/rand"
"os"
"path/filepath"
"runtime"
"strings"
"sync"
"sync/atomic"
"syscall"
Expand All @@ -24,6 +26,10 @@ import (
)

func TestConcurrentReadsAndWrites(t *testing.T) {
if runtime.GOOS == "darwin" && strings.HasSuffix(testenv.Builder(), "-10_14") {
testenv.SkipFlaky(t, 33041)
}

dir, err := ioutil.TempDir("", "renameio")
if err != nil {
t.Fatal(err)
Expand Down

0 comments on commit 4a70ff4

Please sign in to comment.