-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/compile/internal/types2: detect constraint type inference cycles
See the detailed explanations in the code. Fixes #48136. Change-Id: I1667aabfbbff97967913b080c77e7ec04ea82feb Reviewed-on: https://go-review.googlesource.com/c/go/+/347300 Trust: Robert Griesemer <gri@golang.org> Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
- Loading branch information
Showing
2 changed files
with
160 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
src/cmd/compile/internal/types2/testdata/fixedbugs/issue48136.go2
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright 2021 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package p | ||
|
||
func f1[P interface{ *P }]() {} | ||
func f2[P interface{ func(P) }]() {} | ||
func f3[P, Q interface{ func(Q) P }]() {} | ||
func f4[P interface{ *Q }, Q interface{ func(P) }]() {} | ||
func f5[P interface{ func(P) }]() {} | ||
func f6[P interface { *Tree[P] }, Q any ]() {} | ||
|
||
func _() { | ||
f1( /* ERROR cannot infer P */ ) | ||
f2( /* ERROR cannot infer P */ ) | ||
f3( /* ERROR cannot infer P */ ) | ||
f4( /* ERROR cannot infer P */ ) | ||
f5( /* ERROR cannot infer P */ ) | ||
f6( /* ERROR cannot infer P */ ) | ||
} | ||
|
||
type Tree[P any] struct { | ||
left, right *Tree[P] | ||
data P | ||
} | ||
|
||
// test case from issue | ||
|
||
func foo[Src interface { func() Src }]() Src { | ||
return foo[Src] | ||
} | ||
|
||
func _() { | ||
foo( /* ERROR cannot infer Src */ ) | ||
} |