Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/exec: build broken for macOS 10.8 and 10.10 #19775

Closed
bradfitz opened this issue Mar 30, 2017 · 3 comments
Closed

os/exec: build broken for macOS 10.8 and 10.10 #19775

bradfitz opened this issue Mar 30, 2017 · 3 comments
Labels
FrozenDueToAge OS-Darwin
Milestone
Go1.8.1

Comments

@bradfitz
Copy link
Contributor

https://golang.org/cl/38742 broke the macOS 10.8 and 10.10 builders.

https://build.golang.org/log/5657b820d02b88ae95ee64e713f38070b0ff0393

##### Testing race detector
ok  	runtime/race	4.368s
ok  	flag	1.044s
ok  	os/exec	3.099s
# testmain
/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: warning: option -s is obsolete and being ignored
ld: internal error: atom not found in symbolIndex(__ZN11__sanitizer12InternalSortINS_18InternalMmapVectorINS_20StackDepotReverseMap10IdDescPairEEEPFbRKS3_S6_EEEvPT_mT0_) for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2017/03/29 15:38:38 Failed: exit status 2
# testmain
/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: warning: option -s is obsolete and being ignored
ld: internal error: atom not found in symbolIndex(__ZN11__sanitizer12InternalSortINS_18InternalMmapVectorINS_20StackDepotReverseMap10IdDescPairEEEPFbRKS3_S6_EEEvPT_mT0_) for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

FAIL	flag [build failed]
# testmain
/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: warning: option -s is obsolete and being ignored
ld: internal error: atom not found in symbolIndex(__ZN11__sanitizer12InternalSortINS_18InternalMmapVectorINS_20StackDepotReverseMap10IdDescPairEEEPFbRKS3_S6_EEEvPT_mT0_) for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

FAIL	os/exec [build failed]
@bradfitz bradfitz added this to the Go1.9 milestone Mar 30, 2017
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/38799 mentions this issue.

@rsc rsc modified the milestones: Go1.8.1, Go1.9 Mar 30, 2017
@rsc rsc mentioned this issue Mar 30, 2017
Closed
@rsc
Copy link
Contributor

rsc commented Apr 5, 2017

Opening for cherry-pick.

@rsc rsc reopened this Apr 5, 2017
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/39606 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 5, 2017
@rsc
[release-branch.go1.8] cmd/link: do not pass -s through to host linke…
3a8841b 
…r on macOS

This keeps the host linker from printing
ld: warning: option -s is obsolete and being ignored

Fixes #19775.

Change-Id: I18dd4e4b3f59cbf35dad770fd65e6baea5a7347f
Reviewed-on: https://go-review.googlesource.com/38851
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/39606
TryBot-Result: Gobot Gobot <gobot@golang.org>
@rsc rsc closed this as completed Apr 5, 2017
lparth pushed a commit to lparth/go that referenced this issue Apr 13, 2017
@rsc @lparth
cmd/link: do not pass -s through to host linker on macOS
0149653 
This keeps the host linker from printing
ld: warning: option -s is obsolete and being ignored

Fixes golang#19775.

Change-Id: I18dd4e4b3f59cbf35dad770fd65e6baea5a7347f
Reviewed-on: https://go-review.googlesource.com/38851
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Apr 5, 2018
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Darwin
Projects
None yet
Milestone
Go1.8.1
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot