Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/bug: sync issue body format with GitHub template #26751

Closed
myitcv opened this issue Aug 1, 2018 · 9 comments
Closed

cmd/go/internal/bug: sync issue body format with GitHub template #26751

myitcv opened this issue Aug 1, 2018 · 9 comments
Labels
FrozenDueToAge GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.13

Comments

@myitcv
Copy link
Member

myitcv commented Aug 1, 2018

go bug populates a Github issue in the order below, as opposed to https://github.com/golang/go/blob/b8669ef1ceabd386b58a99b4e2f4e67915fec428/.github/ISSUE_TEMPLATE

Not critical clearly but maybe nice to bring in line? cc @andybons?

Please answer these questions before submitting your issue. Thanks!

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

What did you expect to see?

What did you see instead?

Does this issue reproduce with the latest release (go1.10.3)?

System details

go version devel +6b9c782f9f Wed Aug 1 00:57:00 2018 +0000 linux/amd64
GOARCH="amd64"
GOBIN="/home/myitcv/.mountpoints/x/src/myitcv.io/.bin"
GOCACHE="/home/myitcv/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/myitcv/.mountpoints/x"
GOPROXY=""
GORACE=""
GOROOT="/home/myitcv/gos"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/.mountpoints/x/src/myitcv.io/go.mod"
GOROOT/bin/go version: go version devel +6b9c782f9f Wed Aug 1 00:57:00 2018 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel +6b9c782f9f Wed Aug 1 00:57:00 2018 +0000
uname -sr: Linux 4.15.0-29-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename:	bionic
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.27-3ubuntu1) stable release version 2.27.
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 1, 2018
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Aug 1, 2018
@andybons
Copy link
Member

andybons commented Aug 1, 2018

Really good first bug for anyone interested. Thanks for the report, Paul!

@joshblakeley
Copy link

Working on this

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/127495 mentions this issue: cmd/go: update go bug to be consistent with Github issue template

@darkLord19
Copy link
Contributor

Is this issue still open?

@myitcv
Copy link
Member Author

myitcv commented Oct 7, 2018

Yes @joshblakeley is working on this

@dmitshur dmitshur added the GoCommand cmd/go label Nov 4, 2018
@dmitshur dmitshur mentioned this issue Nov 4, 2018
Closed
@dmitshur dmitshur changed the title cmd/go: go bug populates template in different order to Github template cmd/go/internal/bug: sync issue body format with GitHub template Nov 4, 2018
@dmitshur dmitshur modified the milestones: Unplanned, Go1.12 Nov 4, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Nov 4, 2018

@joshblakeley Please take the latest changes to the GitHub issue template in CL 138295 into account (see #28583 for more background).

Adding release-blocker label so we don't forget about this issue, I'd like it to get into 1.12.

@deblasis
Copy link

Hi guys, any objection if I PR this?

I started looking into Go few days ago and I fell in love... in order to learn a bit more about it while contributing back, I wanted to pick up an easy task :)

I have worked out an implementation that downloads the issue template straight from github (similarly to the version check) and replaces the go version, go env and the latest version check bit as well.

The end result is basically along the lines:

https://github.com/golang/go/issues/new?body=%3C%21--+Please+answer+these+questions+before+submitting+your+issue.+Thanks%21+--%3E%0A%0A%23%23%23+What+version+of+Go+are+you+using+%28%60go+version%60%29%3F%0A%0A%3Cpre%3E%0Ago+version+devel+%2B6d5caf38e3+Thu+Nov+22+02%3A59%3A55+2018+%2B0000+linux%2Famd64%0A%0A%0A%3C%2Fpre%3E%0A%0A%23%23%23%23+Does+this+issue+reproduce+with+the+latest+release+%28go1.11.2%29%3F%0A%0A%0A%0A%0A%0A%0A%23%23%23+What+operating+system+and+processor+architecture+are+you+using+%28%60go+env%60%29%3F%0A%0A%3Cdetails%3E%3Csummary%3E%3Ccode%3Ego+env%3C%2Fcode%3E+Output%3C%2Fsummary%3E%3Cbr%3E%3Cpre%3E%0AGOARCH%3D%22amd64%22%0AGOBIN%3D%22%22%0AGOCACHE%3D%22%2Fhome%2Fadeblasis%2F.cache%2Fgo-build%22%0AGOEXE%3D%22%22%0AGOFLAGS%3D%22%22%0AGOHOSTARCH%3D%22amd64%22%0AGOHOSTOS%3D%22linux%22%0AGOOS%3D%22linux%22%0AGOPATH%3D%22%2Fmnt%2Fc%2Fdev%2Fgo%22%0AGOPROXY%3D%22%22%0AGORACE%3D%22%22%0AGOROOT%3D%22%2Fmnt%2Fc%2Fdev%2FOSS%2Fgo%22%0AGOTMPDIR%3D%22%22%0AGOTOOLDIR%3D%22%2Fmnt%2Fc%2Fdev%2FOSS%2Fgo%2Fpkg%2Ftool%2Flinux_amd64%22%0AGCCGO%3D%22gccgo%22%0ACC%3D%22gcc%22%0ACXX%3D%22g%2B%2B%22%0ACGO_ENABLED%3D%221%22%0AGOMOD%3D%22%22%0ACGO_CFLAGS%3D%22-g+-O2%22%0ACGO_CPPFLAGS%3D%22%22%0ACGO_CXXFLAGS%3D%22-g+-O2%22%0ACGO_FFLAGS%3D%22-g+-O2%22%0ACGO_LDFLAGS%3D%22-g+-O2%22%0APKG_CONFIG%3D%22pkg-config%22%0AGOGCCFLAGS%3D%22-fPIC+-m64+-pthread+-fmessage-length%3D0+-fdebug-prefix-map%3D%2Ftmp%2Fgo-build814503179%3D%2Ftmp%2Fgo-build+-gno-record-gcc-switches%22%0Auname+-sr%3A+Linux+4.4.0-17763-Microsoft%0ADistributor+ID%3A%09Ubuntu%0ADescription%3A%09Ubuntu+18.04.1+LTS%0ARelease%3A%0918.04%0ACodename%3A%09bionic%0A%2Flib%2Fx86_64-linux-gnu%2Flibc.so.6%3A+GNU+C+Library+%28Ubuntu+GLIBC+2.27-3ubuntu1%29+stable+release+version+2.27.%0A%0A%0A%3C%2Fpre%3E%3C%2Fdetails%3E%0A%0A%23%23%23+What+did+you+do%3F%0A%0A%3C%21--%0AIf+possible%2C+provide+a+recipe+for+reproducing+the+error.%0AA+complete+runnable+program+is+good.%0AA+link+on+play.golang.org+is+best.%0A--%3E%0A%0A%0A%0A%23%23%23+What+did+you+expect+to+see%3F%0A%0A%0A%0A%23%23%23+What+did+you+see+instead%3F%0A%0A

Shall I PR so that you guys can have a look? :)

@myitcv
Copy link
Member Author

myitcv commented Nov 22, 2018

@deblasis this is already being worked on, but thank you for the offer in any case. Please see https://golang.org/cl/127495

deblasis added a commit to deblasis/go that referenced this issue Nov 22, 2018
@deblasis
Fixes golang#26751
0bc9df4
@deblasis
Copy link

Oh nice one! I didn't see any reference to the CL on googlesource (I am not familiar with it... yet) and I can't see any link or updates here on github regarding the isue being worked on.
The latest update was this one #26751 (comment) when I started.
Well, another time then!

@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
myitcv pushed a commit to myitcvforks/go that referenced this issue Mar 25, 2019
@joshblakeley @myitcv
cmd/go: update go bug to be more consistent with Github issue template
7e1e56b 
As a result of using go env, the following new environment variables are
shown as part of the env section:

+CGO_CFLAGS="-g -O2"
+CGO_CPPFLAGS=""
+CGO_CXXFLAGS="-g -O2"
+CGO_FFLAGS="-g -O2"
+CGO_LDFLAGS="-g -O2"
+PKG_CONFIG="pkg-config"
+GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build612849170=/tmp/go-build -gno-record-gcc-switches"

Fixes golang#26751

Change-Id: I32baca1c3c06d08068dad0041a43a1f5532bd91e
@golang golang locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
8 participants
@andybons @dmitshur @ianlancetaylor @myitcv @gopherbot @darkLord19 @deblasis @joshblakeley