Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/app/appengine: automatically hide and stop testing old versions #34097

Closed
dmitshur opened this issue Sep 5, 2019 · 2 comments
Closed

x/build/app/appengine: automatically hide and stop testing old versions #34097

dmitshur opened this issue Sep 5, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 5, 2019 •
edited
Loading

We make a change like CL 193477 every 6 months. It's usually a one line diff, but it still needs to be remembered, made, reviewed, and deployed each time.

Maybe it's time we automate it to reduce the amount of manual work to be done for each release.

By now, we have an endpoint MaintnerServiceClient.ListGoReleases that we can use to do this more easily. E.g.:

$ go run golang.org/x/build/maintner/maintq list-releases
major:1 minor:13 [...]
major:1 minor:12 [...]

/cc @golang/osp-team

Edit on 2020-02-28: Found a related older issue #21556.
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. FeatureRequest labels Sep 5, 2019
@dmitshur dmitshur added this to the Unreleased milestone Sep 5, 2019
@dmitshur dmitshur mentioned this issue Sep 5, 2019
Closed
@bradfitz
Copy link
Contributor

We don't really even need to make an RPC.

It already reads from the datastore first and then uses that map to filter. We could just encode the policy into the dashboard instead (last two releases) and not list out what the last two releases are. We have the various branch/version parsing code now too, which makes it easier.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Sep 11, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/194643 mentions this issue: app/appengine: automate the hiding of old release branches

codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@bradfitz @codebien
app/appengine: automate the hiding of old release branches
476dac9 
Also, because this is the first CL in this package to add tests, add a
helper to return the right template filename depending on the
environment (go test vs prod) so tests don't panic in init.

Fixes golang/go#34097
Updates golang/go#34116

Change-Id: I4b3e83c2417611cfbdc32e27941dbb90687eb509
Reviewed-on: https://go-review.googlesource.com/c/build/+/194643
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur mentioned this issue Feb 29, 2020
Closed
@golang golang locked and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot