Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

check error for os.Setenv in parse_test.go #472

Merged
merged 3 commits into from
Aug 18, 2020

Conversation

antcs
Copy link
Contributor

@antcs antcs commented Aug 17, 2020

Description

Found some missing error checks for the os.SetEnv() method in mockgen/parse_test.go.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests

Reviewer Notes

  • The code flow looks good.
  • Tests added.

Release Notes

/

Fixes: #473

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codyoss
Copy link
Member

codyoss commented Aug 17, 2020

@antcs can you please create an issue for this PR. We like to discuss things before making any code changes and figure out what use cases things cover.

@antcs
Copy link
Contributor Author

antcs commented Aug 17, 2020

@codyoss I opened a new issue: #473

@antcs
Copy link
Contributor Author

antcs commented Aug 17, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mockgen/parse_test.go Outdated Show resolved Hide resolved
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small thing, thanks

mockgen/parse_test.go Outdated Show resolved Hide resolved
@codyoss codyoss merged commit 7b53c4d into golang:master Aug 18, 2020
@codyoss
Copy link
Member

codyoss commented Aug 18, 2020

@antcs Thanks for your contribution 🎆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing error checks for os.Setenv in parse_test.go
3 participants