protoc-gen-go: add stability warning to XxxServer and XxxClient #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the lack of stability guarantees provided for service Server and Client interfaces, as hightlighted in grpc/grpc-go#2318 and grpc/grpc-go#3024, this change adds a godoc line that both warns users and suggests the canonical workaround. The structure of the godoc text is styled after an open proposal, golang/go#34409, thus may need to be changed, but attempts to play well with the tooling ecosystem, as was done for deprecated with golang/go#10909.
|
The gRPC code generator will be moved over the gRPC project itself soon. Feel free to re-submit this to https://github.com/grpc/grpc-go when that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the lack of stability guarantees provided for service Server and
Client interfaces, as hightlighted in grpc/grpc-go#2318 and
grpc/grpc-go#3024, this change adds a godoc line that both warns users
and suggests the canonical workaround.
The structure of the godoc text is styled after an open proposal,
golang/go#34409, thus may need to be changed, but attempts to play well
with the tooling ecosystem, as was done for deprecated with
golang/go#10909.