-
Notifications
You must be signed in to change notification settings - Fork 577
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
unix: drop support for pre-1.12 direct syscalls on darwin
Go 1.12 and newer are using libSystem for syscalls on darwin. Go 1.11 is the last release to use direct syscalls. It hasn't been supported since the release of Go 1.13 in September 2019, so drop support for direct syscalls. Change-Id: I2baf6f3d1031de8e474dc770369a25147e5efe2a Reviewed-on: https://go-review.googlesource.com/c/sys/+/250437 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
- Loading branch information
Showing
17 changed files
with
0 additions
and
8,990 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
6fcdbc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit makes the build fail with Go 1.12 on macOS.
SYS_GETDIRENTRIES64
is still used atsys/unix/syscall_darwin.1_12.go
Line 23 in 131dc92
syscall_darwin.1_12.go
and updatego.mod
.6fcdbc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @itchyny. We use Gerrit for comments on changes, so usually people don't check GitHub. Thus, I copied your comment to https://golang.org/cl/250437 and will send a follow-up CL. The intention was to still keep compatibility for Go 1.12 for a while and only drop support for Go 1.11 and earlier.
6fcdbc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent https://golang.org/cl/251317 with a fix.
6fcdbc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your quick fix.
6fcdbc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit makes mac-os in go.1.13.11 fail. Could you please help
vendor/github.com/shirou/gopsutil/internal/common/common_darwin.go:39:3: undefined: unix.SYS___SYSCTL
vendor/github.com/shirou/gopsutil/internal/common/common_darwin.go:57:3: undefined: unix.SYS___SYSCTL
6fcdbc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use GitHub as our primary review platform. Please comment on Gerrit, at https://golang.org/cl/250437. I will copy this comment there. Thanks.
6fcdbc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tklauser @ianlancetaylor this appears to have broken dockertest as well: ory/dockertest#212