Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unix: remove absolute path of pwd from mkall.sh #161

Closed
wants to merge 1 commit into from
Closed

unix: remove absolute path of pwd from mkall.sh #161

wants to merge 1 commit into from

Conversation

oxzi
Copy link
Contributor

@oxzi oxzi commented Jun 3, 2023 •
edited by dmitshur
Loading

The pwd command does not always reside under /bin for all Linux
distributions. As a $PATH is otherwise always assumed, here too.

@oxzi
unix: remove absolute path of pwd from mkall.sh
ff9227d 
The pwd binary does not always resides under /bin for all Linux
distributions. As a $PATH is otherwise always assumed with, here too.
@gopherbot
Copy link

This PR (HEAD: ff9227d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/500656 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/500656.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/500656.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/500656.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/500656.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jun 4, 2023
@oxzi @gopherbot
unix: remove absolute path of pwd from mkall.sh
ff98eae 
The pwd command does not always reside under /bin for all Linux
distributions. As a $PATH is otherwise always assumed, here too.

Change-Id: I8a9b65fedc0bdd6b963f30e69d5c98b1550326cd
GitHub-Last-Rev: ff9227d
GitHub-Pull-Request: #161
Reviewed-on: https://go-review.googlesource.com/c/sys/+/500656
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@dmitshur
Copy link
Contributor

dmitshur commented Jun 4, 2023

Closing because this PR has been merged via CL 500656 as commit ff98eae.

(Normally gerritbot does this, but sometimes it needs help due to golang/go#35867.)

@dmitshur dmitshur closed this Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxzi @gopherbot @dmitshur