Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/cilium/cilium: GHSA-c66w-hq56-4q97 #393

Closed
GoVulnBot opened this issue Mar 24, 2022 · 3 comments
Closed
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-c66w-hq56-4q97, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
github.com/cilium/cilium 1.9.5 >= 1.9.0, <= 1.9.4

See doc/triage.md for instructions on how to triage this report.

package: github.com/cilium/cilium
additional_packages:
  - package: github.com/cilium/cilium
    versions:
      - introduced: TODO (earliest fixed "1.8.8", vuln range ">= 1.8.3, <= 1.8.7")
  - package: github.com/cilium/cilium
    versions:
      - introduced: TODO (earliest fixed "1.7.15", vuln range ">= 1.7.8, <= 1.7.14")
versions:
  - introduced: TODO (earliest fixed "1.9.5", vuln range ">= 1.9.0, <= 1.9.4")
description: "## Impact\n\nUnder certain conditions, ICMP Echo Request sent to a Cilium
    endpoint from an actor may bypass a network policy which _disallows_ access from
    the actor to the endpoint, but _allows_ from the endpoint to the actor. This does
    _NOT_ apply to UDP and TCP traffic.\n\nThe actor is either a pod or a cluster
    host or a remote host.\n\nThe following conditions must be met:\n1. Network policies
    have been created which:\n  a) do not allow access from the actor to the endpoint;\n
    \ b) allow access from the endpoint to the actor and does not specify neither
    protocol nor port. \n2. The endpoint has sent ICMP Echo Request to the actor with
    the ICMP identifier X.\n3. The actor sends ICMP Echo Request to the endpoint with
    the same ICMP identifier X.\n4. The request from the actor (3.) is sent before
    the Cilium's conntrack GC has removed the previously created conntrack entry (2.).\n\n##
    Detailed description\n\nSee https://github.com/cilium/cilium/commit/dfb008a9099c4da1e0fd964c899c43ee13280b0e
    (v1.9.x), https://github.com/cilium/cilium/commit/ff6ebae6efca1bd991302b464dea428512823e79
    (v1.8.x), https://github.com/cilium/cilium/commit/472bbeff75161979c317ab21d563f826291b5f37
    (v1.7.x).\n\n## Example\n\n```\n$ kubectl run server --image=quay.io/cilium/net-test:v1.0.0
    --restart=Never -- sleep 3600\n$ kubectl run client --image=quay.io/cilium/net-test:v1.0.0
    --restart=Never -- sleep 3600\n$ cat <<EOF | kubectl apply -f\napiVersion: networking.k8s.io/v1\nkind:
    NetworkPolicy\nmetadata:\n  name: server-netpol # allow client->server\nspec:\n
    \ podSelector:\n    matchLabels:\n      run: server\n  ingress:\n  - from:\n    -
    podSelector:\n        matchLabels:\n          run: client\n  policyTypes:\n  -
    Ingress\n---\napiVersion: networking.k8s.io/v1\nkind: NetworkPolicy\nmetadata:\n
    \ name: client-netpol # deny any->client\nspec:\n  podSelector:\n    matchLabels:\n
    \     run: client\n  policyTypes:\n  - Ingress\nEOF\n\n$ kubectl exec -ti server
    -- xping -c1 -x666 $CLIENT_POD_IP\nPING 10.154.0.50 (10.154.0.50): 56 data bytes\n^C\n---
    10.154.0.50 ping statistics ---\n1 packets transmitted, 0 packets received, 100%
    packet loss   <--- \"client-netpol\" policy denied\ncommand terminated with exit
    code 1\n\n$ kubectl exec -ti client -- xping -c1 -x666 $SERVER_POD_IP\nPING 10.154.1.16
    (10.154.1.16): 56 data bytes\n64 bytes from 10.154.1.16: seq=0 ttl=60 time=0.822
    ms\n\n--- 10.154.1.16 ping statistics ---\n1 packets transmitted, 1 packets received,
    0% packet loss   <--- \"server-netpol\" policy allowed\nround-trip min/avg/max
    = 0.822/0.822/0.822 ms\n\n$ kubectl exec -ti server -- xping -c1 -x666 $CLIENT_POD_IP\nPING
    10.154.0.50 (10.154.0.50): 56 data bytes\n64 bytes from 10.154.0.50: seq=0 ttl=60
    time=0.527 ms\n\n--- 10.154.0.50 ping statistics ---\n1 packets transmitted, 1
    packets received, 0% packet loss   <--- \"client-netpol\" policy bypassed\nround-trip
    min/avg/max = 0.527/0.527/0.527 ms\n```\n\n## For more information\n\nIf you have
    any questions or comments about this advisory:\n\n- Open an issue in [Cilium Issues](https://github.com/cilium/cilium/issues)\n-
    Email us at security@cilium.io"
published: 2021-05-21T14:32:37Z
last_modified: 2021-05-21T14:32:37Z
ghsas:
  - GHSA-c66w-hq56-4q97

@neild
Copy link
Contributor

neild commented Jun 16, 2022

Vulnerability in tool.

@neild neild closed this as completed Jun 16, 2022
@neild neild added excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module. and removed NotGoVuln labels Aug 10, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592767 mentions this issue: data/reports: unexclude 50 reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/607217 mentions this issue: data/reports: unexclude 20 reports (15)

gopherbot pushed a commit that referenced this issue Aug 21, 2024
  - data/reports/GO-2022-0367.yaml
  - data/reports/GO-2022-0368.yaml
  - data/reports/GO-2022-0369.yaml
  - data/reports/GO-2022-0372.yaml
  - data/reports/GO-2022-0374.yaml
  - data/reports/GO-2022-0375.yaml
  - data/reports/GO-2022-0377.yaml
  - data/reports/GO-2022-0378.yaml
  - data/reports/GO-2022-0381.yaml
  - data/reports/GO-2022-0387.yaml
  - data/reports/GO-2022-0388.yaml
  - data/reports/GO-2022-0389.yaml
  - data/reports/GO-2022-0390.yaml
  - data/reports/GO-2022-0392.yaml
  - data/reports/GO-2022-0393.yaml
  - data/reports/GO-2022-0395.yaml
  - data/reports/GO-2022-0396.yaml
  - data/reports/GO-2022-0398.yaml
  - data/reports/GO-2022-0405.yaml
  - data/reports/GO-2022-0406.yaml

Updates #367
Updates #368
Updates #369
Updates #372
Updates #374
Updates #375
Updates #377
Updates #378
Updates #381
Updates #387
Updates #388
Updates #389
Updates #390
Updates #392
Updates #393
Updates #395
Updates #396
Updates #398
Updates #405
Updates #406

Change-Id: I001f245aa4d9225668c2b30e3d5b4ca7a7e9b3b3
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/607217
Commit-Queue: Tatiana Bradley <tatianabradley@google.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.
Projects
None yet
Development

No branches or pull requests

4 participants