This repository has been archived by the owner on Jun 25, 2019. It is now read-only.
Implement source rate limiting #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, gosdm will keep polling all devices at highest possible speed. This leads to high CPU load and is of limited use for human consumption, e.g. in the web ui. Rate limiting is only applied for MQTT output.
With this PR, rate limiting is move to the device scheduler and will halt the scheduling go routine until the cool down time for the selected rate has been achieved. Rate limits are still specified in seconds, it needs to be verified if this should be milliseconds instead.
Builds on #88.