Skip to content

Commit

Permalink
Reduce warnings to info level with a warning icon (#397)
Browse files Browse the repository at this point in the history
With direct WIF, there are now many legitimate use cases for not
specifying a project_id or having a local checkout.
  • Loading branch information
sethvargo authored Feb 25, 2024
1 parent 51342a1 commit bf02f20
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion dist/main/index.js

Large diffs are not rendered by default.

12 changes: 7 additions & 5 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ export async function run(logger: Logger) {
// repository.
const githubWorkspaceIsEmpty = await isEmptyDir(githubWorkspace);
if (githubWorkspaceIsEmpty) {
logger.warning(
`The "create_credentials_file" option is true, but the current ` +
logger.info(
`⚠️ The "create_credentials_file" option is true, but the current ` +
`GitHub workspace is empty. Did you forget to use ` +
`"actions/checkout" before this step? If you do not intend to ` +
`share authentication with future steps in this job, set ` +
Expand Down Expand Up @@ -198,9 +198,11 @@ export async function run(logger: Logger) {

// Set the project ID environment variables to the computed values.
if (!projectID) {
logger.warning(
`Unable to compute project ID from inputs, skipping export. Please ` +
`specify the "project_id" input directly.`,
logger.info(
`⚠️ Failed to a project ID from the given inputs. Neither the ` +
`"project_id" output nor any environment variables will be ` +
`exported. If you require these values in other steps, specify the ` +
`"project_id" input directly.`,
);
} else {
setOutput('project_id', projectID);
Expand Down

0 comments on commit bf02f20

Please sign in to comment.